jsonwebtoken Algorithm Confusion Vulnerability Fix (GHSA-wm9h-9m49-7xx4) Analysis

Vulnerability Overview This vulnerability involves algorithm confusion (RSA-HS256) in the library due to improper handling of non-whitespace prefixes in keys (GHSA-wm9h-9m49-7xx4). Specifically, when a key starts with non-whitespace characters, the library fails to correctly identify the key type, potentially leading to security vulnerabilities. Impact Scope Affected Versions: Specific versions of the library. Affected Algorithm: RSA-HS256 algorithm. Potential Risks: Attackers may exploit this vulnerability to forge HMAC signatures, thereby bypassing authentication mechanisms. Remediation Plan 1. Key Prefix Handling: - When detecting the key type, first remove the non-whitespace prefix from the key to ensure the key starts with the standard PEM format. - Use the method to remove non-whitespace characters from the key, ensuring the key starts with or . 2. Key Type Detection: - When detecting the key type, use the method to ensure the key starts with the standard PEM format. - If the key starts in a non-standard format, reject the key and return an error message. 3. Code Modifications: - In the file, modify the and functions to ensure the key starts with the standard PEM format. - In the file, add test cases to verify that the patched code correctly handles keys with non-whitespace prefixes. POC Code `` -----BEGIN...-----` header, or flags it as an HMAC // secret when no header is present anywhere. Both detectors MUST use this and // classify by the leading header of the slice, so their handling can never // drift apart (the drift is how this CVE lineage stayed incomplete -- // GHSA-wm9h-9m49-7xx4 / CVE-2026-34956 / CVE-2023-48223). function locatePem(trimmedKey) { const pemStart = trimmedKey.search(pemBeginMatcher); if (pemStart === -1) { return { pem: null, isRawSecret: true }; } return { pem: trimmedKey.slice(pemStart), isRawSecret: false }; } function performDetectPrivateKeyAlgorithm(key, providedAlgorithm) { const trimmedKey = key.trim(); if (trimmedKey.match(publickeyPemMatcher) const { pem, isRawSecret } = locatePem(trimmedKey); if (isRawSecret) { return 'HS256'; } if (pem.match(publickeyPemMatcher) throw new TokenError(TokenError.codes.invalidKey, 'Public keys are not supported for signing.'); } const pemData = trimmedKey.match(privatekeyPemMatcher); const pemData = pem.match(privatekeyPemMatcher); if (pemData) { return 'RS256'; } // A PEM header is present but it is neither a supported private key nor a // public key/certificate: refuse rather than silently using it as a secret throw new TokenError(TokenError.codes.invalidKey, 'Unsupported PEM private key.'); } let keyData; case 'RSA': // pkcs1 format - Can only be RSA key return 'RS256'; case 'EC': // sect format - Can only be a EC key keyData = ECPublicKey.decode(trimmedKey, 'pem', { label: 'EC PRIVATE KEY' }); keyData = ECPrivateKey.decode(pem, { label: 'EC PRIVATE KEY' }); curveId = keyData.parameters.value.join(','); break; case 'ENCRYPTED': // Can be either RSA or EC key - we'll used the supplied algorithm return 'ENCRYPTED'; default: // pkcs8 keyData = PrivateKey.decode(trimmedKey, 'pem', { label: 'PRIVATE KEY' }); keyData = PrivateKey.decode(pem, 'pem', { label: 'PRIVATE KEY' }); oid = keyData.algorithm.algorithm.join(','); switch (oid) { case '-132,22,164,32': function performDetectPrivateKeyAlgorithm(key, providedAlgorithm) { function performDetectPublicKeyAlgorithm(key) { const trimmedKey = key.trim(); const publickeyPemMatch = trimmedKey.match(publickeyPemMatcher); if (trimmedKey.match(privatekeyPemMatcher)) { const { pem, isRawSecret } = locatePem(trimmedKey); if (isRawSecret) { // Not a PEM, assume a plain secret return rsaAlgorithms; } const publickeyPemMatch = pem.match(publickeyPemMatcher); if (pem.match(privatekeyPemMatcher)) { throw new TokenError(TokenError.codes.invalidKey, 'Private keys are not supported for verifying.'); } else if (publickeyPemMatch && publickeyPemMatch[1] === 'RSA') { // pkcs1 format - Can only be RSA key return rsaAlgorithms; } else if (publickeyPemMatch && trimmedKey.includes(publickeyX509CertMatcher)) { // x509 format - Can only be RSA key return rsaAlgorithms; } else if (publickeyPemMatch && pem.startsWith(publickeyX509CertMatcher)) { // The leading PEM header is neither a public key nor a certificate. Refuse // rather than scanning past it (and would) so this matches the private path // exactly for junk-before-a-real-header input. throw new TokenError(TokenError.codes.invalidKey, 'Unsupported PEM public key.'); } // If the key is a X509 cert we need to convert it let resolveKey = trimmedKey; if (trimmedKey.includes(publickeyX509CertMatcher)) { resolveKey = createPublicKey(trimmedKey).export({ type: 'spki', format: 'pem' }); } let resolveKey = pem; if (pem.startsWith(publickeyX509CertMatcher)) { resolveKey = createPublicKey(pem).export({ type: 'spki', format: 'pem' }); } const keyData = PublicKey.decode(resolveKey, 'pem', { label: 'PUBLIC KEY' }); } } } } } // test/crypto.spec.js const leadingWhitespacePre

Goal Reached Thanks to every supporter — we hit 100%!

jsonwebtoken Algorithm Confusion Vulnerability Fix (GHSA-wm9h-9m49-7xx4) Analysis

More from this source